Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/periph: Add documentation on thread safety and initialization #19794

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

maribu
Copy link
Member

@maribu maribu commented Jul 4, 2023

Contribution description

As the title says.

Testing procedure

The CI will generate a doc preview that can be reviewed.

Issues/PRs references

None

@maribu maribu requested a review from MrKevinWeiss as a code owner July 4, 2023 13:31
@github-actions github-actions bot added Area: doc Area: Documentation Area: drivers Area: Device drivers labels Jul 4, 2023
@chrysn chrysn added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 4, 2023
@maribu maribu added the CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs label Jul 4, 2023
@riot-ci
Copy link

riot-ci commented Jul 4, 2023

Murdock results

✔️ PASSED

6bf23bd drivers/periph: Add documentation on thread safety and initialization

Success Failures Total Runtime
1 0 1 01m:22s

Artifacts

Copy link
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -16,6 +16,64 @@
* defines a standardized interface to access MCU peripherals that is not tied
* to any specific vendor, platform or architecture.
*
* # Initialization and Thread Safety
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread gets turned into a hyperlink thanks to automagic and mqtt paho.

Not sure whether there is anything we can do here -- escaping the word is probably a whack-a-mole...

* | `periph_dac` | user / driver | Partial (no concurrent use of the same DAC line allowed) |
* | `periph_eeprom` | not needed | None (no concurrency whatsoever) |
* | `periph_flashpage` | not needed | None (no concurrency whatsoever) |
* | `periph_gpio` | not needed | Limited (reads are fine, concurrent writes to pins on distinct ports work) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* | `periph_gpio` | not needed | Limited (reads are fine, concurrent writes to pins on distinct ports work) |
* | `periph_gpio` | not needed | Limited (reads are fine, concurrent writes to pins are allowed on distinct ports) |

A lot of things work that are not allowed.

@benpicco
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 23, 2023

👎 Rejected by PR status

@aabadie
Copy link
Contributor

aabadie commented Sep 2, 2023

Please squash!

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 5, 2023
@aabadie
Copy link
Contributor

aabadie commented Sep 5, 2023

bors merge

bors bot added a commit that referenced this pull request Sep 5, 2023
19794: drivers/periph: Add documentation on thread safety and initialization r=aabadie a=maribu



Co-authored-by: Marian Buschsieweke <marian.buschsieweke@posteo.net>
@aabadie
Copy link
Contributor

aabadie commented Sep 5, 2023

bors cancel

@bors
Copy link
Contributor

bors bot commented Sep 5, 2023

Canceled.

@aabadie
Copy link
Contributor

aabadie commented Sep 5, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 5, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit da7deb5 into RIOT-OS:master Sep 5, 2023
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
@maribu maribu deleted the periph/doc branch December 5, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants