sys/board_software_reset: add module for soft-reset button #19833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: build system
benpicco
added
Type: enhancement
benpicco
force-pushed
the
board_software_reset
branch
from
9e7642a to
c8630a7
Compare
The reset pin of the nrf52 needs to be flashed once in a non-volatile configuration register, there is https://github.com/RIOT-OS/RIOT/tree/master/dist/tools/nrf52_resetpin_cfg for that purpose. I don't think your contribution here conflicts with that though. |
bergzand
requested changes
Aug 11, 2023
aabadie
reviewed
Sep 6, 2023
| */ | ||
|
|
||
| /** | ||
| * @@defgroup module_board_software_reset board_software_reset |
There was a problem hiding this comment.
Suggested change
| * @@defgroup module_board_software_reset board_software_reset | |
| * @defgroup board_software_reset Board software reset | |
| * @ingroup sys |
Should fix the not showing up documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This moves the
board_software_resetmodule frome104-bt50xxa-tbto a common place and let'snrf52840dkmake use of it.Testing procedure
Flash any application on
nrf52840dk- a press on the button labeled RESET (SW5) should now reset the board.In
masterthis button did nothing.Issues/PRs references