pkg/arduino_adafruit_sensor: fix dependencies #19839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the dependencies of the `arduino_adafruit_sensor` package, which previously relied on the `arduino` feature. This feature no longer exists, as it was split into more fine granular features. However, the module should never have used that feature directly in the first place, but rather just use the arduino module. This in turn depends on the correct features.
maribu
added
Type: bug
github-actions
bot
added
Area: pkg
maribu
commented
Jul 20, 2023
| @@ -1,4 +1,3 @@ | |||
| FEATURES_REQUIRED += arduino | |||
| FEATURES_REQUIRED += cpp | |||
There was a problem hiding this comment.
This is also technically not needed, as arduino depends on cpp. However, the package uses C++ code itself, (and not only indirectly via the arduino module), so I think we should keep this one.
benpicco
approved these changes
Jul 20, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
Backport provided in #19840 |
|
Thx :) |
bors bot
added a commit
that referenced
this pull request
Jul 20, 2023
19840: pkg/arduino_adafruit_sensor: fix dependencies [backport 2023.07] r=benpicco a=maribu # Backport of #19839 ### Contribution description This fixes the dependencies of the `arduino_adafruit_sensor` package, which previously relied on the `arduino` feature. This feature no longer exists, as it was split into more fine granular features. However, the module should never have used that feature directly in the first place, but rather just use the arduino module. This in turn depends on the correct features. ### Testing procedure `tests/arduino_adafruit_sensor` should again be supported by boards that have the features required by the `arduino` module. ### Issues/PRs references Fallout of #19759 Co-authored-by: Marian Buschsieweke <marian.buschsieweke@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This fixes the dependencies of the
arduino_adafruit_sensorpackage, which previously relied on thearduinofeature. This feature no longer exists, as it was split into more fine granular features. However, the module should never have used that feature directly in the first place, but rather just use the arduino module. This in turn depends on the correct features.Testing procedure
tests/arduino_adafruit_sensorshould again be supported by boards that have the features required by thearduinomodule.Issues/PRs references
Fallout of #19759