Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_ipv6_nib: fix for border router with non-6lo interfaces #19900

Merged
merged 1 commit into from
Aug 24, 2023
Merged

gnrc_ipv6_nib: fix for border router with non-6lo interfaces #19900

merged 1 commit into from
Aug 24, 2023

Conversation

benpicco
Copy link
Contributor

Contribution description

A border router should not send router advertisements on it's 6LoWPAN interfaces, but if it also has classic IPv6 downstream interfaces it should very much do so.

Testing procedure

Issues/PRs references

@benpicco benpicco requested a review from fabian18 August 23, 2023 22:27
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Aug 23, 2023
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Area: sys Area: System labels Aug 23, 2023
@riot-ci
Copy link

riot-ci commented Aug 23, 2023 •
edited
Loading

Murdock results

✔️ PASSED

d383796 gnrc_ipv6_nib: fix for border router with non-6lo interfaces

Success Failures Total Runtime
7939 0 7939 14m:19s

Artifacts

@benpicco benpicco mentioned this pull request Aug 23, 2023
Closed
@benpicco benpicco force-pushed the gnrc_sixlowpan_border_router-heterogenous branch from e1ddce9 to 43aeee8 Compare August 23, 2023 22:47
@github-actions github-actions bot added the Area: sys Area: System label Aug 23, 2023
fabian18
fabian18 reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@fabian18 fabian18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me. But I do not fully understand your description. Did you observe a non-6LN interface send RAs for every stored border router?

sys/net/gnrc/network_layer/ipv6/nib/_nib-router.c Outdated Show resolved Hide resolved
@benpicco
gnrc_ipv6_nib: fix for border router with non-6lo interfaces
d383796 
A border router should not send router advertisements on it's 6LoWPAN
interfaces, but if it also has classic IPv6 downstream interfaces it
should very much do so.
@benpicco benpicco force-pushed the gnrc_sixlowpan_border_router-heterogenous branch from 43aeee8 to d383796 Compare August 24, 2023 10:05
@benpicco
Copy link
Contributor Author

benpicco commented Aug 24, 2023 •
edited
Loading

Did you observe a non-6LN interface send RAs for every stored border router?

No, I did observe the non-6LN interface not send any RAs because the while ((abr = _nib_abr_iter(abr))) loop would never be executed as the ABR list was empty.

fabian18
fabian18 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@fabian18 fabian18 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@benpicco
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Aug 24, 2023
@bors @benpicco
Merge #19900
7c5faca 
19900: gnrc_ipv6_nib: fix for border router with non-6lo interfaces r=benpicco a=benpicco





Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de>
@benpicco
Copy link
Contributor Author

bors cancel

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 24, 2023

Canceled.

@bors
Copy link
Contributor

bors bot commented Aug 24, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 8e5a67b into RIOT-OS:master Aug 24, 2023
@benpicco benpicco deleted the gnrc_sixlowpan_border_router-heterogenous branch August 25, 2023 10:39
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabian18 fabian18 fabian18 approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.10
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @fabian18 @MrKevinWeiss