Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/mtd_default: fix for boards that define MTD_NUMOF #19907

Merged
merged 1 commit into from
Aug 30, 2023
Merged

drivers/mtd_default: fix for boards that define MTD_NUMOF #19907

merged 1 commit into from
Aug 30, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Aug 29, 2023 •
edited
Loading

Contribution description

When a board defines MTD_NUMOF, the condition will not be taken so MTD_BOARD_NUMOF is left undefined - causing mtd_default_get_dev() to always return NULL.

Testing procedure

tests/drivers/mtd_raw should work again for boards that define MTD_NUMOF

Issues/PRs references

@github-actions github-actions bot added the Area: drivers Area: Device drivers label Aug 29, 2023
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 29, 2023
@benpicco benpicco requested a review from gschorcht August 29, 2023 13:49
@riot-ci
Copy link

riot-ci commented Aug 29, 2023

Murdock results

✔️ PASSED

aef1a71 drivers/mtd_default: fix for boards that define MTD_NUMOF

Success Failures Total Runtime
7937 0 7937 14m:57s

Artifacts

gschorcht
gschorcht approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@aabadie
Copy link
Contributor

aabadie commented Aug 30, 2023

bors merge

@gschorcht
Copy link
Contributor

bors merge

@aabadie Thanks, I forgot to do it after approving this PR.

@bors
Copy link
Contributor

bors bot commented Aug 30, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f1df27b into RIOT-OS:master Aug 30, 2023
@benpicco benpicco deleted the mtd_default_get_dev branch August 30, 2023 16:37
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.10
Development

Successfully merging this pull request may close these issues.
5 participants
@benpicco @riot-ci @aabadie @gschorcht @MrKevinWeiss