examples/gcoap: add saml11-xpro to CI boards with insufficient memory #19933
Conversation
|
bors merge |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
miri64
added
Type: enhancement
|
(the problem is that your fix in #19927 increased the binary size of applications including |
|
bors merge |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors cancel |
19933: examples/gcoap: add saml11-xpro to CI boards with insufficient memory r=miri64 a=krzysztof-cabaj ### Contribution description Bors run for PR #19927 reveals that ```examples\gcoap``` do not fit in saml11-xpro board. I checked and this same linker error also appears on current master branch. This PR add sampl11-xpro board to the Makefile.ci BOARD_INSUFFICIENT_MEMORY list. ### Testing procedure See logs from bors https://ci.riot-os.org/details/073c5dadc6ba4bc8a613edb78a1a4a2d ### Issues/PRs references PR #19927 Co-authored-by: krzysztof-cabaj <kcabaj@gmail.com>
|
bors cancel |
|
Canceled. |
|
bors merge |
19923: boards: add Silabs EFM32 Giant Gecko GG11 Starter Kit r=miri64 a=gschorcht ### Contribution description The PR adds the support for the EFM32GG11B family and the Silabs EFM32 Giant Gecko GG11 Starter Kit board. The Silabs EFM32 Giant Gecko GG11 has the following on-board features: - EFM32GG11B MCU with 2 MB flash and 512 kB RAM - J-Link USB debugger - 176x176 RGB LCD (not supported) - 2 user buttons, 2 user RGB LEDs and a touch slider - Si7021 Relative Humidity and Temperature Sensor - Si7210 Hall-Effect Sensor (not supported) - USB OTG interface (Device mode supported) - 32 MByte Quad-SPI Flash (not supported yet) - SD card slot (not supported yet, follow-up PR based on PR #19760) - RJ-45 Ethernet (not supported) - Dual microphones (not supported) ### Testing procedure Basic tests should work. ### Issues/PRs references 19927: sys/shell/ping: fix ping packet size overflow r=miri64 a=krzysztof-cabaj ### Contribution description In #19829 `@mchesser` point out integer overflow in the ```ping``` command and API. This PR fix this issue in two ways: 1) Add protection in the API. 2) Add protection in the user command. ### Testing procedure Without this PR passing negative number to the ```ping -s``` option cause segmentation fault, for example in the ```example/gnrc_networking```: ``` > ping -s -7 ::1 ping -s -7 ::1 Segmentation fault ``` With this PR user shows appropriate warning test: ``` > ping -s -7 ::1 ping -s -7 ::1 ICMPv6 datagram size should be in range <0, 65527>. > ``` ### Issues/PRs references Issue #19829 19933: examples/gcoap: add saml11-xpro to CI boards with insufficient memory r=miri64 a=krzysztof-cabaj ### Contribution description Bors run for PR #19927 reveals that ```examples\gcoap``` do not fit in saml11-xpro board. I checked and this same linker error also appears on current master branch. This PR add sampl11-xpro board to the Makefile.ci BOARD_INSUFFICIENT_MEMORY list. ### Testing procedure See logs from bors https://ci.riot-os.org/details/073c5dadc6ba4bc8a613edb78a1a4a2d ### Issues/PRs references PR #19927 Co-authored-by: Gunar Schorcht <gunar@schorcht.net> Co-authored-by: krzysztof-cabaj <kcabaj@gmail.com>
|
Build failed (retrying...): |
19927: sys/shell/ping: fix ping packet size overflow r=miri64 a=krzysztof-cabaj ### Contribution description In #19829 `@mchesser` point out integer overflow in the ```ping``` command and API. This PR fix this issue in two ways: 1) Add protection in the API. 2) Add protection in the user command. ### Testing procedure Without this PR passing negative number to the ```ping -s``` option cause segmentation fault, for example in the ```example/gnrc_networking```: ``` > ping -s -7 ::1 ping -s -7 ::1 Segmentation fault ``` With this PR user shows appropriate warning test: ``` > ping -s -7 ::1 ping -s -7 ::1 ICMPv6 datagram size should be in range <0, 65527>. > ``` ### Issues/PRs references Issue #19829 19933: examples/gcoap: add saml11-xpro to CI boards with insufficient memory r=miri64 a=krzysztof-cabaj ### Contribution description Bors run for PR #19927 reveals that ```examples\gcoap``` do not fit in saml11-xpro board. I checked and this same linker error also appears on current master branch. This PR add sampl11-xpro board to the Makefile.ci BOARD_INSUFFICIENT_MEMORY list. ### Testing procedure See logs from bors https://ci.riot-os.org/details/073c5dadc6ba4bc8a613edb78a1a4a2d ### Issues/PRs references PR #19927 Co-authored-by: krzysztof-cabaj <kcabaj@gmail.com>
|
Build failed (retrying...): |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
|
Wow! ... i think that this will be simple and straight-forward PR. @miri64 thank for support - with initial version of the code as well as help with bors. @benpicco thanks for valuable comment in PR #19927 - as this fix was merged I don't know does it make sense to rollback it. UPDATE. Should I add to list all samX boards with 16KiB or try to save some memory in PR #19927 as @benpicco suggests? |
The latter please, and you can just cherry-pick a |
Contribution description
Bors run for PR #19927 reveals that
examples\gcoapdo not fit in saml11-xpro board.I checked and this same linker error also appears on current master branch.
This PR add sampl11-xpro board to the Makefile.ci BOARD_INSUFFICIENT_MEMORY list.
Testing procedure
See logs from bors https://ci.riot-os.org/details/073c5dadc6ba4bc8a613edb78a1a4a2d
Issues/PRs references
PR #19927