Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcoap_dns: Housekeeping with regards to draft status #20015

Merged
merged 2 commits into from
Oct 25, 2023
Merged

gcoap_dns: Housekeeping with regards to draft status #20015

merged 2 commits into from
Oct 25, 2023

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 25, 2023

Contribution description

Some housekeeping on gcoap_dns:

  • Update URL to draft, it is a Working Group draft since last year (September 2022)
  • Update application/dns-message Content-Format: In draft-ietf-core-dns-over-coap-03 it was set to 553

Testing procedure

Only reading and successful compilation is required.

Issues/PRs references

❌

miri64 added 2 commits October 25, 2023 10:54
@miri64
gcoap_dns: Update draft URL
410be58 
The DoC draft is a working group draft since September 2022
@miri64
coap: Set COAP_FORMAT_DNS_MESSAGE to 553
63fd564 
Set since draft-ietf-core-dns-over-coap-03
@github-actions github-actions bot added Area: network Area: Networking Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System labels Oct 25, 2023
@miri64 miri64 force-pushed the gcoap_dns/cleanup/housekeeping branch from 14cd563 to 63fd564 Compare October 25, 2023 09:01
@miri64 miri64 requested review from benpicco and JKRhb October 25, 2023 09:01
@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 25, 2023
@riot-ci
Copy link

riot-ci commented Oct 25, 2023

Murdock results

✔️ PASSED

63fd564 coap: Set COAP_FORMAT_DNS_MESSAGE to 553

Success Failures Total Runtime
7953 0 7953 17m:29s

Artifacts

JKRhb
JKRhb approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@miri64
Copy link
Member Author

miri64 commented Oct 25, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 25, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 2b9e828 into RIOT-OS:master Oct 25, 2023
26 checks passed
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKRhb JKRhb JKRhb approved these changes

@benpicco benpicco Awaiting requested review from benpicco

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2024.01
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @riot-ci @JKRhb @MrKevinWeiss