-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/nrf5x_common: clean up UART implementation #20111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
State: WIP
State: The PR is still work-in-progress and its code is not in its final presentable form yet
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
labels
Nov 27, 2023
github-actions
bot
added
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Area: cpu
Area: CPU/MCU ports
labels
Nov 27, 2023
The functions `uart_poweron()`, `uart_poweroff()` and `uart_mode()` can share code between the UART (UART without EasyDMA) and UARTE (UART with EasyDMA) implementations, so let's do that.
maribu
force-pushed
the
cpu/nrf5x_common/cleanup_uart
branch
from
November 27, 2023 08:49
1a7234a
to
659ef97
Compare
maribu
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
State: WIP
State: The PR is still work-in-progress and its code is not in its final presentable form yet
labels
Nov 27, 2023
benpicco
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple cleanup
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Dec 10, 2023
Thx :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: cpu
Area: CPU/MCU ports
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The functions
uart_poweron()
,uart_poweroff()
anduart_mode()
can share code between the UART (UART without EasyDMA) and UARTE (UART with EasyDMA) implementations, so let's do that.Testing procedure
UART should still work including switching modes - best checked with a logic analyzer attached to verify the output - for:
UART
peripheral (UART without EasyDMA), so any nRF51*UARTE
peripheral (UART with EasyDMA) but no support for two stop bits, so e.g. nRF52832UARTE
peripheral (UART with EasyDMA) plus support for two stop bits, so e.g. nRF52840 / nRF53 / nRF9160 / ...Issues/PRs references
Follow up to / made possible by #20102