Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanocoap_sock: implement FETCH methods #20238

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Jan 9, 2024

Contribution description

Mostly for completeness' sake, works just like PUT/POST.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System labels Jan 9, 2024
@benpicco benpicco requested review from chrysn and bergzand January 9, 2024 11:43
Copy link
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward enough, fits the pattern.

@chrysn chrysn added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 9, 2024
@riot-ci
Copy link

riot-ci commented Jan 9, 2024

Murdock results

✔️ PASSED

7240f70 nanocoap_sock: implement FETCH methods

Success Failures Total Runtime
8085 0 8085 16m:48s

Artifacts

@benpicco benpicco added this pull request to the merge queue Jan 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2024
@maribu
Copy link
Member

maribu commented Jan 10, 2024

The CI failure was a fluke

@maribu maribu added this pull request to the merge queue Jan 10, 2024
Merged via the queue into RIOT-OS:master with commit 5fa94b5 Jan 10, 2024
27 checks passed
@benpicco benpicco deleted the nanocoap_sock_fetch branch January 10, 2024 12:19
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants