Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/avr8_common: allow to build with !periph_pm #20247

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

pm_layered is a DEFAULT_MODULE for all other arches so we can disable it - do the same for AVR8.

Also add a fallback for panic() if periph_pm is not enabled.

Testing procedure

DISABLE_MODULE += core_thread pm_layered
FEATURES_BLACKLIST += periph_pm

now allows to minimize simple programs.

Issues/PRs references

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 11, 2024
@benpicco benpicco requested review from nandojve and maribu January 11, 2024 20:22
@benpicco benpicco added Platform: AVR Platform: This PR/issue effects AVR-based platforms Area: pm Area: (Low) power management labels Jan 11, 2024
@benpicco benpicco force-pushed the cpu/avr8-pm_layered branch from 7a5b73f to ce36ca5 Compare January 11, 2024 20:23
@github-actions github-actions bot added Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports labels Jan 11, 2024
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 11, 2024
@benpicco benpicco enabled auto-merge January 11, 2024 20:56
@riot-ci
Copy link

riot-ci commented Jan 11, 2024

Murdock results

✔️ PASSED

ce36ca5 core/panic: fix build with !periph_pm

Success Failures Total Runtime
8101 0 8101 11m:12s

Artifacts

@benpicco benpicco added this pull request to the merge queue Jan 11, 2024
Merged via the queue into RIOT-OS:master with commit 47b5eeb Jan 11, 2024
32 checks passed
@benpicco benpicco deleted the cpu/avr8-pm_layered branch January 12, 2024 06:39
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: pm Area: (Low) power management CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants