-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stm32l1: initial port for the nucleo-l1 board and stm32l1 cpu #2026
Conversation
@@ -0,0 +1 @@ | |||
FEATURES_PROVIDED += periph_gpio periph_uart periph_spi periph_i2c periph_cpuid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add also cpp
as it works fine :-)
01c0a2d
to
92d64a6
Compare
@haukepetersen pidapingpingbang |
What made the shell working? (Might test at home or here if someone returns my board ;-).) |
Tried with Olegs board, but I am not able to flash. Not quite sure why - st-flash says the board has 0kb flash... Seems off. |
9f41904
to
4478bcb
Compare
added nucleo-l1 wiki page |
4478bcb
to
e45648c
Compare
# define tools used for building the project | ||
export PREFIX = arm-none-eabi- | ||
export CC = $(PREFIX)gcc | ||
export AR = $(PREFIX)ar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could add the c++ stuff in this Makefile as well.
@thomaseichinger I still haven't tested, code looks good as for some minor details. Will test tomorrow so we can include it in the release. |
d84bf27
to
1211739
Compare
addressed @haukepetersen's comments. |
#define the default port depending on the host OS | ||
OS := $(shell uname) | ||
ifeq ($(OS),Linux) | ||
PORT ?= /dev/ttyACM0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when using an external UART-to-USB converter, these are normally found under /dev/ttyUSB0
under Linux. Can you adjust this?
The I also tried different combinations of connecting my TX cable to different RX and TX labeled pins in the nucleo board -> no effect. |
export OFLAGS = -O binary | ||
export FFLAGS = $(HEXFILE) | ||
export DEBUGGER_FLAGS = $(RIOTBOARD)/$(BOARD)/dist/gdb.conf $(ELFFILE) | ||
export TERMFLAGS += -p "$(PORT)"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
superfluous "
@haukepetersen as mentioned offline, at least on my hardware, using the UART adapter you can only receive while for sending you have to connect to the on-board UART adapter resulting in two shells, one for sending and you can see the result in the other. I tried multiple pin configurations and neither found any errata sheet or similar which sheds some light on this strange behaviour. I will add a hint in the wiki. |
392c2bc
to
614afca
Compare
updated addressing @haukepetersen's and @OlegHahm's comments. |
#define the default port depending on the host OS | ||
OS := $(shell uname) | ||
ifeq ($(OS),Linux) | ||
PORT ?= /dev/ttyUSB0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this to /dev/ttyACM0
, and the board is able to communicate out-of-the-box using the integrated USB-UART adapter without any external hw...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't work on my PC.
ok, just found some minor things, will ack once these are fixed. Good job! |
and don't forget to squash... |
614afca
to
ccd8b45
Compare
ccd8b45
to
07d76d7
Compare
addressed @haukepetersen's comments, rebased and squashed. |
I changed the wiki in respect of the UART mystery. Travis passed. |
Looking good. ACK and go. |
stm32l1: initial port for the nucleo-l1 board and stm32l1 cpu
Known issues:
shell input currently not working