Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32l1: initial port for the nucleo-l1 board and stm32l1 cpu #2026

Merged
merged 1 commit into from
Jan 12, 2015

Conversation

thomaseichinger
Copy link
Member

Known issues:

  • shell input currently not working

@thomaseichinger thomaseichinger added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Nov 18, 2014
@thomaseichinger thomaseichinger added this to the Release 2014.12 milestone Nov 18, 2014
@@ -0,0 +1 @@
FEATURES_PROVIDED += periph_gpio periph_uart periph_spi periph_i2c periph_cpuid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add also cpp as it works fine :-)

@thomaseichinger thomaseichinger force-pushed the stm32l1 branch 5 times, most recently from 01c0a2d to 92d64a6 Compare November 20, 2014 14:02
@thomaseichinger
Copy link
Member Author

@haukepetersen pidapingpingbang

@OlegHahm
Copy link
Member

What made the shell working? (Might test at home or here if someone returns my board ;-).)

@haukepetersen
Copy link
Contributor

Tried with Olegs board, but I am not able to flash. Not quite sure why - st-flash says the board has 0kb flash... Seems off.

@thomaseichinger
Copy link
Member Author

added nucleo-l1 wiki page

@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Nov 26, 2014
# define tools used for building the project
export PREFIX = arm-none-eabi-
export CC = $(PREFIX)gcc
export AR = $(PREFIX)ar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add the c++ stuff in this Makefile as well.

@haukepetersen
Copy link
Contributor

@thomaseichinger I still haven't tested, code looks good as for some minor details. Will test tomorrow so we can include it in the release.

@thomaseichinger
Copy link
Member Author

addressed @haukepetersen's comments.

#define the default port depending on the host OS
OS := $(shell uname)
ifeq ($(OS),Linux)
PORT ?= /dev/ttyACM0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using an external UART-to-USB converter, these are normally found under /dev/ttyUSB0 under Linux. Can you adjust this?

@haukepetersen
Copy link
Contributor

The default example does not work as expected. I get all the normal output up to Welcome to RIOT!, but I can not send data to the board. Also the RX/TX pin labels of the nucleo board seem strange to me, I have to connect RX from the USB-to-UART converter to RX on the nucleo board... very strange...

I also tried different combinations of connecting my TX cable to different RX and TX labeled pins in the nucleo board -> no effect.

export OFLAGS = -O binary
export FFLAGS = $(HEXFILE)
export DEBUGGER_FLAGS = $(RIOTBOARD)/$(BOARD)/dist/gdb.conf $(ELFFILE)
export TERMFLAGS += -p "$(PORT)""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superfluous "

@OlegHahm OlegHahm modified the milestones: Release NEXT MAJOR, Release 2014.12 Dec 19, 2014
@thomaseichinger
Copy link
Member Author

@haukepetersen as mentioned offline, at least on my hardware, using the UART adapter you can only receive while for sending you have to connect to the on-board UART adapter resulting in two shells, one for sending and you can see the result in the other. I tried multiple pin configurations and neither found any errata sheet or similar which sheds some light on this strange behaviour. I will add a hint in the wiki.

@thomaseichinger
Copy link
Member Author

updated addressing @haukepetersen's and @OlegHahm's comments.

#define the default port depending on the host OS
OS := $(shell uname)
ifeq ($(OS),Linux)
PORT ?= /dev/ttyUSB0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to /dev/ttyACM0, and the board is able to communicate out-of-the-box using the integrated USB-UART adapter without any external hw...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't work on my PC.

@haukepetersen
Copy link
Contributor

ok, just found some minor things, will ack once these are fixed. Good job!

@haukepetersen
Copy link
Contributor

and don't forget to squash...

@thomaseichinger thomaseichinger removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Jan 12, 2015
@thomaseichinger
Copy link
Member Author

addressed @haukepetersen's comments, rebased and squashed.

@thomaseichinger
Copy link
Member Author

I changed the wiki in respect of the UART mystery. Travis passed.

@haukepetersen
Copy link
Contributor

Looking good. ACK and go.

haukepetersen added a commit that referenced this pull request Jan 12, 2015
stm32l1: initial port for the nucleo-l1 board and stm32l1 cpu
@haukepetersen haukepetersen merged commit b435a48 into RIOT-OS:master Jan 12, 2015
@OlegHahm OlegHahm modified the milestone: Release 2015.12 Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants