-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/sodaq-sara-sff: add status pin for SARA #20279
Conversation
This looks good to me. |
ping @keestux |
c38b855
to
b079586
Compare
/** | ||
* @name SARA (UBlox) STATUS | ||
* | ||
* This is the V_INT of the SARA. | ||
* @{ | ||
*/ | ||
#define SARA_STATUS_PIN GPIO_PIN(PA, 28) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static test is failing again
/** | |
* @name SARA (UBlox) STATUS | |
* | |
* This is the V_INT of the SARA. | |
* @{ | |
*/ | |
#define SARA_STATUS_PIN GPIO_PIN(PA, 28) | |
#define SARA_STATUS_PIN GPIO_PIN(PA, 28) /**< This is the V_INT of the board */ |
I think this would make static-test happy
Sorry about the delay. I've pushed a fixup as you suggested |
@keestux I think we're all good now. |
0d2ac48
to
08862b2
Compare
Squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
Contribution description
This adds a pin definition for SARA_STATUS on the sodaq-sara-sff board.
Testing procedure
Testing is only possible with this specific board, of course. Here is a code snippet to see it in operation.
The output should then be: