Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/pkg/lwip: include default-radio-settings.inc.mk #20325

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Feb 1, 2024

Contribution description

For the release tests we decided to randomize the PAN ID to not interfere with ongoing RIOT-based experiments in the testbed (see RIOT-OS/Release-Specs#300). However, lwIP currently does not include the Makefile to set the PAN ID at compile time. This fixes that.

Testing procedure

Apply the following patch

diff --git a/drivers/netdev/ieee802154.c b/drivers/netdev/ieee802154.c
index cf5a39d4b4..9068a1e8fa 100644
--- a/drivers/netdev/ieee802154.c
+++ b/drivers/netdev/ieee802154.c
@@ -44,6 +44,7 @@ void netdev_ieee802154_reset(netdev_ieee802154_t *dev)
 
     /* Initialize PAN ID and call netdev::set to propagate it */
     dev->pan = CONFIG_IEEE802154_DEFAULT_PANID;
+    printf("PANID: 0x%04x\n", dev->pan);
     dev->netdev.driver->set(&dev->netdev, NETOPT_NID, &dev->pan, sizeof(dev->pan));
 
 #if IS_USED(MODULE_IEEE802154_SECURITY)

Then compile and flash tests/pkg/lwip to a board that has an IEEE 802.15.4 radio. Open a terminal and reboot. The node should now print PANID: 0x0023. If you then recompile and flash tests/pkg/lwip with DEFAULT_PAN_ID set to another value in the environment variables, e.g. DEFAULT_PAN_ID=0x1234, without this PR, the output will still be PANID: 0x0023, with this PR it will be PANID: 0x1234.

Issues/PRs references

Required for RIOT-OS/Release-Specs#300.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Feb 1, 2024
@miri64 miri64 requested a review from MrKevinWeiss February 1, 2024 08:57
@github-actions github-actions bot removed the Area: pkg Area: External package ports label Feb 1, 2024
@riot-ci
Copy link

riot-ci commented Feb 1, 2024

Murdock results

✔️ PASSED

fb9b6b9 tests/pkg/lwip: include default-radio-settings.inc.mk

Success Failures Total Runtime
63 0 63 01m:09s

Artifacts

Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@MrKevinWeiss MrKevinWeiss added this pull request to the merge queue Feb 1, 2024
Merged via the queue into RIOT-OS:master with commit e6844f8 Feb 1, 2024
31 checks passed
@miri64 miri64 deleted the tests/enh/lwip-radio-settings branch February 2, 2024 06:53
@miri64
Copy link
Member Author

miri64 commented Feb 2, 2024

Backport provided in #20330

@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants