Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/tiny_strerror: fix compilation on LLVM #20483

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Mar 19, 2024

Contribution description

Mixing address spaces is something LLVM doesn't like (for good reason). This re-organized the code a bit so that this does not happen anymore, even on AVR.

Testing procedure

The function should still be semantically equivalent; ideally even the machine code generated is not changed (or at least not larger).

Issues/PRs references

Split out of #16924

@github-actions github-actions bot added the Area: sys Area: System label Mar 19, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 19, 2024
@maribu maribu force-pushed the sys/tiny_strerror/llvm branch from bb2c94c to 2208c83 Compare March 19, 2024 15:10
Mixing address spaces is something LLVM doesn't like (for good
reason). This re-organized the code a bit so that this does not
happen anymore, even on AVR.

Split out of RIOT-OS#16924
@maribu maribu force-pushed the sys/tiny_strerror/llvm branch from 2208c83 to 7775fa7 Compare March 19, 2024 15:12
@maribu maribu enabled auto-merge March 19, 2024 16:38
@riot-ci
Copy link

riot-ci commented Mar 19, 2024

Murdock results

✔️ PASSED

7775fa7 sys/tiny_strerror: fix compilation on LLVM

Success Failures Total Runtime
10006 0 10008 10m:14s

Artifacts

@maribu maribu added this pull request to the merge queue Mar 19, 2024
Merged via the queue into RIOT-OS:master with commit 4caa3bc Mar 20, 2024
28 checks passed
@maribu maribu deleted the sys/tiny_strerror/llvm branch March 20, 2024 12:33
@maribu
Copy link
Member Author

maribu commented Mar 20, 2024

Thx :)

@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants