Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using egrep #20522

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Avoid using egrep #20522

merged 1 commit into from
Mar 29, 2024

Conversation

keestux
Copy link
Contributor

@keestux keestux commented Mar 28, 2024

This is a very simple change in dist/tools/eclipsesym/cmdline2xml.sh, just change egrep in grep -E.

The egrep and fgrep commands have been deprecated since 2007. Beginning with GNU Grep 3.8, calling these commands will now issue a warning to the user that instead they should use grep -E and grep -F, respectively.

The egrep and fgrep commands have been deprecated since 2007. Beginning
with GNU Grep 3.8, calling these commands will now issue a warning to the
user that instead they should use grep -E and grep -F, respectively.
@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Mar 28, 2024
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but LGTM.

@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 29, 2024
@riot-ci
Copy link

riot-ci commented Mar 29, 2024

Murdock results

✔️ PASSED

39cc420 eclipsesym/cmdline2xml.sh: avoid egrep

Success Failures Total Runtime
1 0 1 57s

Artifacts

@dylad dylad added this pull request to the merge queue Mar 29, 2024
Merged via the queue into RIOT-OS:master with commit 48a8e65 Mar 29, 2024
27 checks passed
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
@keestux keestux deleted the fix/eclipsesym-script branch June 2, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants