Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/doc: Adafruit Feather nRF52840 Sense is popular #20597

Merged

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Apr 19, 2024

Contribution description

The Adafruit Feather nRF52840 Sense has seen a lot of love recently, is part of a tutorial series at https://github.com/inetrg/exercises, and universities have stocks of them.

I think that counts as popular.

Testing procedure

Look at the generated docs.

AOB

It may make sense to have an "add one, remove one" policy, but I don't know which. Remove arduino-mega2560, maybe? (It sits between the other two Arduino, and it's not like we're really recommending it.)

@chrysn chrysn requested review from maribu and MrKevinWeiss April 19, 2024 09:18
@github-actions github-actions bot added Area: doc Area: Documentation Area: boards Area: Board ports labels Apr 19, 2024
@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 19, 2024
@riot-ci
Copy link

riot-ci commented Apr 19, 2024

Murdock results

✔️ PASSED

5b01060 boards/doc: Adafruit Feather nRF52840 Sense is popular

Success Failures Total Runtime
1 0 1 01m:14s

Artifacts

Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.
Doc preview looks good to me.

@dylad
Copy link
Member

dylad commented Apr 19, 2024

Remove arduino-mega2560, maybe?

Don't have opinion on this. Let's see if someone really want to remove one.

@chrysn chrysn added this pull request to the merge queue Apr 19, 2024
Merged via the queue into RIOT-OS:master with commit 3ba49d5 Apr 19, 2024
27 checks passed
@chrysn chrysn deleted the adafruit-sense-is-popular branch April 21, 2024 18:12
@mguetschow mguetschow added this to the Release 2024.07 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants