-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/wamr: updated package to WAMR 1.3.3 #20691
Conversation
@@ -1,10 +1,10 @@ | |||
PKG_NAME=wamr | |||
PKG_URL=https://github.com/bytecodealliance/wasm-micro-runtime.git | |||
ifeq ($(PKG_BLEADING),1) | |||
ifeq ($(PKG_BLEEDING),1) | |||
PKG_VERSION=main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this doesn't work, you can just drop it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does work for me ( just tested)
$ cd <RIOT>/examples/wasm
$ PKG_BLEADING=1 make
$ cd <RIOT>/build/pkg/wamr
$ git status
On branch main
Your branch is up to date with 'origin/main'.
$ cd <RIOT>/examples/wasm
$ make
$ cd <RIOT>/build/pkg/wamr
$ git status
HEAD detached at dc4dcc3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching the typo
Sadly this currently the only package to support a instantaneous test with the current upstream main branch.
The PKG_VERSION=
supports hashes, tags, and branches main
is a branch.
We usually only use hashes because everything else can change, and we might have to do much work to keep track especially if projects change API, or we apply patches. At least the patches are very avoidable with wamr, since the upstream is very responsive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on native, looks good to me
Contribution description
This PR updates WAMR to its 1.3.3 version referenced by this commit hash : 3f5e2bd23bcb8eb3767c8e17789c6a2e3e912a08.
I'd like some opinions about whether the
PKG_BLEEDING
condition (and variable) should be kept because this variable is not used somewhere else. Also themain
tag does not exist and anyway tag names are not supported there, only commits hashes are.Testing procedure
Use various boards to see if the example/wamr still work.
I tested it with this example and another homemade one and the behavior was the same as the old version. The tests were made using an arduino nano 33 ble (and sense) and a dwm1001.
Please note that the text+data values are slightly larger but the bss (ram) new use is not significant from what I saw.
Issues/PRs references
N/A