-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build system: clean up netif features #20700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Area: build system
Area: Build system
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
May 27, 2024
github-actions
bot
added
Platform: native
Platform: This PR/issue effects the native platform
Area: boards
Area: Board ports
Platform: ESP
Platform: This PR/issue effects ESP-based platforms
Area: cpu
Area: CPU/MCU ports
labels
May 27, 2024
maribu
force-pushed
the
features/netif-cleanup
branch
2 times, most recently
from
May 28, 2024 16:11
48094c9
to
b0465e2
Compare
In order to extend features based on provided features, we need to check contents of `FEATURES_PROVIDED`.
If a board already provided a netif_% feature (currently only netif_ethernet), the netif feature is automagically provided.
maribu
force-pushed
the
features/netif-cleanup
branch
from
May 28, 2024 18:54
b0465e2
to
6084727
Compare
Use periph_eth instead of esp_eth for the Ethernet peripheral on ESP MCUs for consistency
maribu
force-pushed
the
features/netif-cleanup
branch
from
May 28, 2024 18:59
6084727
to
53f952f
Compare
mguetschow
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! Just a minor documentation suggestion below.
If there is an Ethernet peripheral (periph_eth feature provided), we can conclude that an Ethernet network interface can be provided. Co-authored-by: mguetschow <mikolai.guetschow@tu-dresden.de>
maribu
force-pushed
the
features/netif-cleanup
branch
from
June 3, 2024 10:25
0ec4a93
to
47f52bd
Compare
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: boards
Area: Board ports
Area: build system
Area: Build system
Area: cpu
Area: CPU/MCU ports
Area: tools
Area: Supplementary tools
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: ESP
Platform: This PR/issue effects ESP-based platforms
Platform: native
Platform: This PR/issue effects the native platform
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
netif_%
(currently onlynetif_ethernet
, but more are to come) is provided, thenetif
feature is implicitly providednetif
feature from boards that already providenetif_ethernet
is dropped, consequentlyesp_eth
now instead provideperiph_eth
for consistancyperiph_eth
no longer need to providenetif_ethernet
w5100
,w5500
,enc28j60
,encx24j600
, etc.) would still need to providenetif_ethernet
by handFEATURES_PROVIDED += netif_ethernet
is dropped, relying on it being added implicitlyTesting procedure
This should not change any generated binaries.
Issues/PRs references
Follow up to #20694