Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile.include: place compile_commands.json by rule target #20716

Merged
merged 1 commit into from
May 31, 2024
Merged

Makefile.include: place compile_commands.json by rule target #20716

merged 1 commit into from
May 31, 2024

Conversation

kfessel
Copy link
Contributor

@kfessel kfessel commented May 31, 2024 •
edited
Loading

Contribution description

place compile_commands.json by rule target

Testing procedure

make compile-commands should result in the current compile_commands.json placement:
RIOTBASE if the app if in a subdirectory of that or APPDIR if not

make <somewhere>/compile_commands.json should place it <somewhere>

as i often have separate app an riot but they share a common path its usually

make ../../compile_commands.json or something like that

or

<somewhere>$ make -D <whatever to build> ./compile_commands.json

Issues/PRs references

#19869

@github-actions github-actions bot added the Area: build system Area: Build system label May 31, 2024
@kfessel kfessel requested review from benpicco and maribu May 31, 2024 11:56
@maribu maribu enabled auto-merge May 31, 2024 12:04
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels May 31, 2024
@riot-ci
Copy link

riot-ci commented May 31, 2024

Murdock results

✔️ PASSED

b58b255 Makefile.include: place compile_commands.json by rule target

Success Failures Total Runtime
1 0 1 01m:18s

Artifacts

@maribu maribu added this pull request to the merge queue May 31, 2024
Merged via the queue into RIOT-OS:master with commit 2ef8b21 May 31, 2024
28 checks passed
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@benpicco benpicco Awaiting requested review from benpicco

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Projects
None yet
Milestone
Release 2024.07
Development

Successfully merging this pull request may close these issues.
4 participants
@kfessel @riot-ci @maribu @mguetschow