Remove extraneous bitwise assignment operation on NRF5X_common gpio.c

[steverpalmer]

Contribution description

Removing an extraneous bitwise assignment operation for NRF5X_common gpio.c

Testing procedure

I've been running this on my micro-bit v2 with this fix for a couple of days with no ill effects. However, it is not expected that the changed the behaviour of the code at all.

On my code base, it saves a whole 16 bytes of code :-).

Issues/PRs references

Fixes #20736

[dylad]

Thanks for your PR !
While we are at it, would you mind also fix the same issue a few lines above ?

[steverpalmer]

@dylad I've made the change as requested (I hope).

I've also search every file in the codebase looking for lines that include the character sequences "INTENSET" and "|=" and not found any. Of course, such searches are no guarantee, but I doubt that this is a systemic issue across the code base, just a bit of muscle-memory gone wrong in this one file.

Saves another 16 bytes ;-)

[dylad]

@steverpalmer this looks good to me.
Please squash into a single commit as these changes are on the same file.

[steverpalmer]

Hopefully now squashed.

[dylad]

Great ! One last thing I promise.
Could you rename your commit as per our commit convention ?
Something like 'cpu/nrf5x: fix errorneous mask with INTENSET reg'
You may add the issue reference in the commit description (the second -m option when using 'git commit')

[steverpalmer]

Third attempt luck? Cheers.

[dylad]

ACK.

[riot-ci]

Murdock results

✔️ PASSED

2164352 cpu/nrf5x: fix erroneous mask with INTENSET reg

Success	Failures	Total	Runtime
10160	0	10161	27m:45s

Artifacts

• Documentation preview

[dylad]

Thanks for your fix !