Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/sys/psa_crypto_ecdsa: fix stacksize determination #20760

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

mguetschow
Copy link
Contributor

Contribution description

We tried to specify the stacksize according to the used backend in tests/sys/psa_crypto_ecdsa but failed to do so, if the backend is auto-selected.

This PR moves the stacksize determination to after the default-makefile include.

Testing procedure

make -C tests/sys/psa_crypto_ecdsa BOARD=nrf52840dk flash test

Without this patch, the application crashes.

Issues/PRs references

Introduced in #20545

@mguetschow mguetschow requested review from Einhornhool and removed request for aabadie, leandrolanzieri and MichelRottleuthner June 24, 2024 08:21
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Jun 24, 2024
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 24, 2024
@riot-ci
Copy link

riot-ci commented Jun 24, 2024

Murdock results

✔️ PASSED

cf4cc6c tests/sys/psa_crypto_ecdsa: fix stacksize determination

Success Failures Total Runtime
17 0 17 02m:55s

Artifacts

@mguetschow mguetschow force-pushed the tests-psa-stacksize branch from 050e887 to cf4cc6c Compare June 24, 2024 11:13
@Teufelchen1 Teufelchen1 added this pull request to the merge queue Jun 25, 2024
Merged via the queue into RIOT-OS:master with commit 7595796 Jun 25, 2024
26 checks passed
@mguetschow mguetschow deleted the tests-psa-stacksize branch June 26, 2024 14:43
@mguetschow mguetschow added this to the Release 2024.07 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants