tests/sys/progress_bar: move configuration to app.config #20764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguetschow
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
mguetschow
added
CI: ready for build
miri64
reviewed
Jun 26, 2024
Providing the configuration via Makefile variables if Kconfig is supported by the module may involve some non-determinism in the environment variable that is finally exposed to the python tests. This commit moves the configuration from Makefile to app.config.
mguetschow
force-pushed
the
tests-progressbar-kconfig
branch
from
6a93f12 to
e79cb1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Providing the configuration via Makefile variables if Kconfig is supported by the module may involve some non-determinism in the environment variable that is finally exposed to the python tests. This commit moves the configuration from Makefile to app.config.
Testing procedure
Confirm that the configuration from
app.configis applied locally withmake -C tests/sys/progress_bar all testMerge and wait for the next nightly with fingers crossed.
Issues/PRs references
Follow-up of #20763 and will need to follow-up to remove the debug prints in the python script.