Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/tools/cosy: take BUILD_DIR into account #20789

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

mguetschow
Copy link
Contributor

Contribution description

Symbols coming from packages are not properly recognized as soon as the BUILD_DIR environment variable is used. This PR changes that.

Testing procedure

Configure BUILD_DIR as per the documentation.

Start cosy on any app that uses a third-party package, e.g., dtls-echo:

make -C examples/dtls-echo cosy

On master, this shows

Warning: 893 symbols could not be matched to a path

With this PR, it reduces to

Warning: 527 symbols could not be matched to a path

and the tinydtls symbols are correctly matched.

@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Jul 16, 2024
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 16, 2024
@mguetschow mguetschow requested review from benpicco and maribu July 16, 2024 15:17
@riot-ci
Copy link

riot-ci commented Jul 16, 2024

Murdock results

✔️ PASSED

6f70ed0 dist/tools/cosy: take BUILD_DIR into account

Success Failures Total Runtime
1 0 1 01m:11s

Artifacts

@Teufelchen1 Teufelchen1 added this pull request to the merge queue Jul 16, 2024
Merged via the queue into RIOT-OS:master with commit 06a19bd Jul 16, 2024
27 checks passed
@mguetschow mguetschow deleted the cosy-build-dir branch July 17, 2024 07:19
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants