Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/dhcpv6: Improve option handling in dhcpv6 advertise #20801

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Teufelchen1
Copy link
Contributor

Contribution description

Hello 🐌

This enhances the handling of the option parsing.

Testing procedure

CI should be enough + a good review. Maybe @miri64?

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Jul 30, 2024
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should there also be similar checks in _parse_advertise()?

@Teufelchen1
Copy link
Contributor Author

Yes. Those are still missing, I wanted to keep the PRs small as I found the surrounding code rather hard to work with.

@Teufelchen1 Teufelchen1 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 30, 2024
@riot-ci
Copy link

riot-ci commented Jul 30, 2024

Murdock results

✔️ PASSED

cc9855b net/dhcpv6: Improve option handling in dhcpv6 advertise

Success Failures Total Runtime
10195 0 10196 14m:49s

Artifacts

@miri64 miri64 added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 31, 2024
@miri64 miri64 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into RIOT-OS:master with commit 11ea4a3 Jul 31, 2024
27 checks passed
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants