-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/native/periph_timer: add missing -lrt to linker flags #20816
Merged
chrysn
merged 1 commit into
RIOT-OS:master
from
maribu:cpu/native/periph_timer/linkflags
Aug 17, 2024
Merged
cpu/native/periph_timer: add missing -lrt to linker flags #20816
chrysn
merged 1 commit into
RIOT-OS:master
from
maribu:cpu/native/periph_timer/linkflags
Aug 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Platform: native
Platform: This PR/issue effects the native platform
Area: cpu
Area: CPU/MCU ports
labels
Aug 17, 2024
Debian 11 on
Debian 11 with this PR:
|
maribu
added
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Aug 17, 2024
chrysn
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this super fast.
I've verified that the only code using the offending function (that I know) is periph_timer on native, and trust your tests.
Thx a bunch! |
Backport provided in #20819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: cpu
Area: CPU/MCU ports
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: native
Platform: This PR/issue effects the native platform
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This (hopefully) fixes #20009 (comment)
Testing procedure
E.g.
make BOARD=native64 -C tests/periph/timer
should now work on Debian 11.Issues/PRs references
#20009 (comment)