bluetil: Ensure advertisement length does not exceed pkt len #20881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: network
|
lgtm. The CI has nitpicks, though. |
benpicco
added
CI: ready for build
|
Maybe @BOZHENG001 wants to have a look. |
|
The code meets its purpose. I never tried, but it seems some errors may occur if the advertisement length exceeds the packet length? In the BLE standard, I do not see such a limit for the advertisement packet length? |
|
I am unsure what action your comment demands? |
|
Sorry for the confusion. Just wanted to know if our change meets the BLE standard or not. If yes, of course I will have no objection. |
|
Okay, took for ever but I found it, page 1432 in the current bluetooth spec. I think my fix is within the spec. |
|
Cool cool, thanks for the explanation. As long as it meets the standard, we are still BLE. |
miri64
approved these changes
Oct 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Hey 🦪
this fixes an erroneous advertisement parsing, in which the length of the adv. was inherently trusted.
Testing procedure
Good review should be sufficient.