net/dhcpv6: Improve option parsing in dhcpv6 advertise #20882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
CI: ready for build
miri64
reviewed
Oct 1, 2024
Teufelchen1
force-pushed
the
fix/dhcpv6
branch
from
ae273b1 to
f88285d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Hello 🐿️
This adds missed size checks for the type conversions.
Please note that
dhcpv6_opt_ia_pd_tanddhcpv6_opt_ia_na_tmake use of flexible array member - so I am not super sure if the check is enough.Testing procedure
A good review by @miri64
Issues/PRs references