boards/common/arduino-zero: Add Arudino SPI mapping #20884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Arduino Zero based boards already provided the feature `arduino_spi`, but were missing the corresponding mapping. This fixes the issue by adding the SPI bus numbers for the ISP SPI bus and the D11D12D13 SPI bus. (And in order to actually add the D11D12D13 SPI bus, the `periph_conf.h` was extended to provide an SPI configuration for it.)
maribu
added
Type: bug
benpicco
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The Arduino Zero based boards already provided the feature
arduino_spi, but were missing the corresponding mapping. This fixes the issue by adding the SPI bus numbers for the ISP SPI bus and the D11D12D13 SPI bus.(And in order to actually add the D11D12D13 SPI bus, the
periph_conf.hwas extended to provide an SPI configuration for it.)Testing procedure
Add an Arduino Ethernet Shield (the classic one with the W5100 chip) on top of an Arduino Zero board (either original or one of the compatible clones) and run:
This will fail to compile on
master(due to the missing SPI defines), but succeed with this PR.Sadly, this will only test the SPI bus already present in the
periph_conf.h, not the one added.Issues/PRs references
None