pkg/littlefs: make use of RIOT's log module instead of pkg provided macros #20894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enoch247
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
github-actions
bot
added
Area: tests
mguetschow
approved these changes
Oct 11, 2024
mguetschow
changed the title
mguetschow
changed the title
This patch replaces the package supplied logging macros with RIOT's. It also removes the requirement that DEVELHELP be defined to enable logging. Instead, logging can be enabled/dissabled via the log level. The patch also replaceses the package's trace macro with RIOT's DEBUG macro.
This patch replaces the package supplied logging macros with RIOT's. It also removes the requirement that DEVELHELP be defined to enable logging. Instead, logging can be enabled/dissabled via the log level.
Enoch247
force-pushed
the
littlefs-logging
branch
from
b187dda to
96e5f14
Compare
done |
mguetschow
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This patch replaces littlefs's logging with RIOT's own logging module.
Testing procedure
Issues/PRs references
Some log messages in the tests needed to be silenced due to this patch also fixing broken support of logging in the package. See #20889.