Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix true and false positives by newer codespell version #20899

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

mguetschow
Copy link
Contributor

Contribution description

The static tests have been failing on master for some time due to codespell findings: https://github.com/RIOT-OS/RIOT/actions/workflows/static-test.yml
That happened probably after some update to the riot/riotbuild docker image, which presumably lead to a version bump of codespell.

This PR adds some new false positives to the ignored-words list and fixes several found true positives throughout the codebase.

Testing procedure

Review typo corrections and newly added false positives.

Static tests in this PR will probably run through anyway as for all the other recent PRs. I'm wondering if the static-test workflow somehow uses a cached version of riot/static-test-tools:latest, since pulling that and executing the codespell check locally there also fails.

@mguetschow mguetschow requested a review from maribu October 9, 2024 11:26
@github-actions github-actions bot added Area: network Area: Networking Area: doc Area: Documentation Area: pkg Area: External package ports Area: drivers Area: Device drivers Area: tools Area: Supplementary tools Area: boards Area: Board ports Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports Area: sys Area: System labels Oct 9, 2024
@maribu maribu enabled auto-merge October 9, 2024 11:32
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 9, 2024
@riot-ci
Copy link

riot-ci commented Oct 9, 2024

Murdock results

✔️ PASSED

f0e6776 treewide: apply codespell corrections

Success Failures Total Runtime
1 0 1 01m:14s

Artifacts

@maribu maribu added this pull request to the merge queue Oct 9, 2024
Merged via the queue into RIOT-OS:master with commit 85172ed Oct 9, 2024
27 checks passed
@mguetschow
Copy link
Contributor Author

Thanks, master is now green again 🎉

@mguetschow mguetschow deleted the static-tests-codespell branch October 10, 2024 08:55
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: drivers Area: Device drivers Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants