Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/adafruit-grand-central-m4-express: provide arduino features #20904

Merged

Conversation

maribu
Copy link
Member

@maribu maribu commented Oct 10, 2024

Contribution description

The board is compatible with Arduino UNO and Arduino MEGA shields and has an ISP connector, so this adds the corresponding features.

This adds the Arduino I/O-mapping for the ISP SPI and provides the corresponding feature.

It appears that the SPI on D11/D12/D13 cannot be provided by a SERCOM, this is under clarification at 1. For now, no I/O mapping for that SPI bus is provided.

Testing procedure

An Arduino Shield that uses the ISP SPI bus (the older ones targeting the AVR based Arduinos still do that) should now work out of the box.

E.g.

USEMODULE=shield_w5100 make -C examples/gnrc_networking BOARD=adafruit-grand-central-m4-express flash term
[...]

2024-10-10 10:28:28,746 # ifconfig
2024-10-10 10:28:28,747 # Iface  6  HWaddr: A6:45:6B:D7:7E:41 
2024-10-10 10:28:28,747 #           L2-PDU:1500  MTU:1500  HL:64  RTR  
2024-10-10 10:28:28,747 #           RTR_ADV  
2024-10-10 10:28:28,748 #           Source address length: 6
2024-10-10 10:28:28,748 #           Link type: wired
2024-10-10 10:28:28,748 #           inet6 addr: fe80::a445:6bff:fed7:7e41  scope: link  VAL
2024-10-10 10:28:28,748 #           inet6 group: ff02::2
2024-10-10 10:28:28,750 #           inet6 group: ff02::1
2024-10-10 10:28:28,750 #           inet6 group: ff02::1:ffd7:7e41
2024-10-10 10:28:28,750 #           inet6 group: ff02::1a
2024-10-10 10:28:28,751 #           
2024-10-10 10:28:28,751 #           Statistics for Layer 2
2024-10-10 10:28:28,751 #             RX packets 0  bytes 0
2024-10-10 10:28:28,751 #             TX packets 1 (Multicast: 1)  bytes 78
2024-10-10 10:28:28,751 #             TX succeeded 0 errors 0
2024-10-10 10:28:28,752 #           Statistics for IPv6
2024-10-10 10:28:28,752 #             RX packets 0  bytes 0
2024-10-10 10:28:28,752 #             TX packets 1 (Multicast: 1)  bytes 64
2024-10-10 10:28:28,752 #             TX succeeded 1 errors 0

Issues/PRs references

None

The board is compatible with Arduino UNO and Arduino MEGA shields and
has an ISP connector, so this adds the corresponding features.

This adds the Arduino I/O-mapping for the ISP SPI and provides the
corresponding feature.

It appears that the SPI on D11/D12/D13 cannot be provided by a SERCOM,
this is under clarification at [1]. For now, no I/O mapping for that
SPI bus is provided.

[1]: https://forums.adafruit.com/viewtopic.php?t=214093
@maribu maribu added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Oct 10, 2024
@maribu maribu enabled auto-merge October 10, 2024 09:36
@riot-ci
Copy link

riot-ci commented Oct 10, 2024

Murdock results

✔️ PASSED

7f68acb boards/adafruit-grand-central-m4-express: provide arduino features

Success Failures Total Runtime
563 0 563 03m:18s

Artifacts

@maribu maribu added this pull request to the merge queue Oct 10, 2024
Merged via the queue into RIOT-OS:master with commit 0f4725e Oct 10, 2024
29 checks passed
@maribu maribu deleted the boards/adafruit-grand-central-m4-express/spi-isp branch October 11, 2024 08:49
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants