Draft: sys/ztimer: gaurd against spurious ISR #20925
Draft
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This patch changes
ztimer_handler()
to properly deal with spurious ISRs. Without the patch, a spurious ISR will potentially cause mutliple timers to fire early. With this patch, these ISRs are properly ignored.The downside of this PR is that it increases the overhead of the ztimer ISR execution. One option would be to only enable it when
DEVELHELP
is set. Another option is to make this the default behavior, but revert to the old behavior for MCU's where theperiph_timer
is well tested and known the never cause spurious ISRs. This would ease porting of new MCUs where the timer driver may not be as mature yet.Testing procedure
Testing procedure is the same as #20924.
Issues/PRs references
periph_timer
could lead to spurious ISRs, and it is only one implementation. It is likely that such errors could exist in other drivers.