Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/emlearn: bump version to 0.17.1 [backport 2024.07] #20929

Conversation

maribu
Copy link
Member

@maribu maribu commented Oct 21, 2024

Backport of #20347

Contribution description

This PR is probably not enough because the new trained model is stored using joblib 1.3 and is not compatible with the joblib version available in the riotdocker image. But an update of joblib (and scikit-learn) in riotdocker should work.

Testing procedure

  • Green CI
  • make -C tests/pkg/emlearn all test works:
make -C tests/pkg/emlearn/ all test
make: Entering directory '/work/riot/RIOT/tests/pkg/emlearn'
Building application "tests_emlearn" for "native" with MCU "native".

"make" -C /work/riot/RIOT/pkg/emlearn/ 
"make" -C /work/riot/RIOT/boards/common/init
"make" -C /work/riot/RIOT/boards/native
"make" -C /work/riot/RIOT/boards/native/drivers
"make" -C /work/riot/RIOT/core
"make" -C /work/riot/RIOT/core/lib
"make" -C /work/riot/RIOT/cpu/native
"make" -C /work/riot/RIOT/cpu/native/periph
"make" -C /work/riot/RIOT/cpu/native/stdio_native
"make" -C /work/riot/RIOT/drivers
"make" -C /work/riot/RIOT/drivers/periph_common
"make" -C /work/riot/RIOT/sys
"make" -C /work/riot/RIOT/sys/auto_init
"make" -C /work/riot/RIOT/sys/libc
"make" -C /work/riot/RIOT/sys/preprocessor
"make" -C /work/riot/RIOT/sys/test_utils/interactive_sync
"make" -C /work/riot/RIOT/sys/test_utils/print_stack_usage
/usr/bin/ld: warning: /work/riot/RIOT/tests/pkg/emlearn/bin/native/tests_emlearn.elf has a LOAD segment with RWX permissions
   text	   data	    bss	    dec	    hex	filename
  74185	    556	  47836	 122577	  1ded1	/work/riot/RIOT/tests/pkg/emlearn/bin/native/tests_emlearn.elf
r
/work/riot/RIOT/tests/pkg/emlearn/bin/native/tests_emlearn.elf  tap0 
RIOT native interrupts/signals initialized.
RIOT native board initialized.
RIOT native hardware initialization complete.

Help: Press s to start test, r to print it is ready
READY
s
START
main(): This is RIOT! (Version: 2024.04-devel-153-g4efd1d-pkg/emlearn/bump_version)
Predicted digit: 6
{ "threads": [{ "name": "idle", "stack_size": 8192, "stack_used": 436 }]}
{ "threads": [{ "name": "main", "stack_size": 12288, "stack_used": 2248 }]}

make: Leaving directory '/work/riot/RIOT/tests/pkg/emlearn'

Issues/PRs references

@maribu maribu added Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master labels Oct 21, 2024
@maribu maribu requested a review from benpicco October 21, 2024 10:54
@github-actions github-actions bot added the Area: build system Area: Build system label Oct 21, 2024
@maribu
Copy link
Member Author

maribu commented Oct 21, 2024

@Teufelchen1 This will be needed to allow back-porting fixes. While we do now pin the docker image locally for runs with BUILD_IN_DOCKER=1, the CI will just use the latest container now matter what. This backports a package upgrade to match the tooling in the CI.

And since starting from this PR newer backports will be tested with the newer container, I also changed the pinning to match that. (This is also enforced by the CI, so it is not only common sense but necessary to get this merged.)

@mguetschow
Copy link
Contributor

Hum, any reasoning why we need this package bump being backported to the last release, especially since the new release is just around the corner?

@maribu
Copy link
Member Author

maribu commented Oct 21, 2024

So that we can backport #20928

@mguetschow
Copy link
Contributor

Yeah, sorry, saw your comment just after I asked. LGTM then in terms of the changes here, but strictly speaking this is then not just a backport of #20347, but also including the CI version bump. Not sure how strict we want to be about that.

@riot-ci
Copy link

riot-ci commented Oct 21, 2024

Murdock results

FAILED

7a7b29c makefiles/docker.inc.mk: bump container pinning

Success Failures Total Runtime
5396 0 9700 09m:46s

Artifacts

@Teufelchen1 Teufelchen1 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 25, 2024
@maribu
Copy link
Member Author

maribu commented Nov 12, 2024

Let's rather push for the new release than trying to fix the CI pipeline of the old one.

@maribu maribu closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants