-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/emlearn: bump version to 0.17.1 [backport 2024.07] #20929
pkg/emlearn: bump version to 0.17.1 [backport 2024.07] #20929
Conversation
@Teufelchen1 This will be needed to allow back-porting fixes. While we do now pin the docker image locally for runs with And since starting from this PR newer backports will be tested with the newer container, I also changed the pinning to match that. (This is also enforced by the CI, so it is not only common sense but necessary to get this merged.) |
Hum, any reasoning why we need this package bump being backported to the last release, especially since the new release is just around the corner? |
So that we can backport #20928 |
Yeah, sorry, saw your comment just after I asked. LGTM then in terms of the changes here, but strictly speaking this is then not just a backport of #20347, but also including the CI version bump. Not sure how strict we want to be about that. |
Let's rather push for the new release than trying to fix the CI pipeline of the old one. |
Backport of #20347
Contribution description
This PR is probably not enough because the new trained model is stored using joblib 1.3 and is not compatible with the joblib version available in the riotdocker image. But an update of joblib (and scikit-learn) in riotdocker should work.
Testing procedure
make -C tests/pkg/emlearn all test
works:Issues/PRs references