sys/net/gnrc_pktbuf_static: add double free detection #20974
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
force-pushed
the
gnrc_pktbuf_static-double-free
branch
from
9bd4954
to
9c6c2f3
Compare
benpicco
added
the
State: WIP
benpicco
force-pushed
the
gnrc_pktbuf_static-double-free
branch
from
9c6c2f3
to
3d1e6f5
Compare
benpicco
removed
the
State: WIP
benpicco
force-pushed
the
gnrc_pktbuf_static-double-free
branch
from
3d1e6f5
to
982af61
Compare
maribu
approved these changes
Nov 12, 2024
benpicco
added
the
CI: ready for build
benpicco
added
the
Type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The basic idea is: all free data is filled with
CANARYbytes, once data is allocated this is overwritten with~CANARY.When data is freed we now check if the chunk is only set to
CANARY- if this happens, it was already freed.Testing procedure
Set
CONFIG_GNRC_PKTBUF_CHECK_USE_AFTER_FREEto1.Issues/PRs references