Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_netif: fix double free with netdev_new_api & gnrc_netif_pktq [backport 2024.10] #20979

Conversation

benpicco
Copy link
Contributor

Backport of #20976

Contribution description

Return early to prevent freeing the same packet again.

Testing procedure

Issues/PRs references

@benpicco benpicco added Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 12, 2024
@benpicco benpicco requested a review from maribu November 12, 2024 14:10
@riot-ci
Copy link

riot-ci commented Nov 12, 2024

Murdock results

✔️ PASSED

7a7a889 gnrc_netif: fix double free with netdev_new_api & gnrc_netif_pktq

Success Failures Total Runtime
10215 0 10215 19m:05s

Artifacts

@maribu maribu added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@maribu maribu added this pull request to the merge queue Nov 13, 2024
Merged via the queue into RIOT-OS:2024.10-branch with commit 3bfbc55 Nov 13, 2024
31 checks passed
@benpicco benpicco deleted the backport/2024.10/gnrc_netif-double-free branch November 13, 2024 21:03
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants