Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/endian: fix build with picolibc #20985

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

benpicco
Copy link
Contributor

Contribution description

picolibc defines those now, so add a guard to prevent conflicts.

Testing procedure

Build with

USEMODULE += picolibc
FEATURES_REQUIRED += picolibc

should work again.

Issues/PRs references

@github-actions github-actions bot added the Area: sys Area: System label Nov 13, 2024
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 13, 2024
@benpicco benpicco requested a review from maribu November 13, 2024 15:08
@riot-ci
Copy link

riot-ci commented Nov 13, 2024

Murdock results

✔️ PASSED

3e8c7d0 sys/endian: fix build with picolibc

Success Failures Total Runtime
10251 0 10251 14m:49s

Artifacts

@maribu maribu added this pull request to the merge queue Nov 13, 2024
Merged via the queue into RIOT-OS:master with commit fe62143 Nov 14, 2024
29 checks passed
@benpicco benpicco deleted the picolibc-endian.h branch November 14, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants