gnrc_netif: fix neighbor statistics with netdev_new_api #21002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
approved these changes
Dec 13, 2024
Comment on lines
34
to
38
| typedef enum { | ||
| NETSTATS_NB_BUSY, /**< Failed due to medium busy */ | ||
| NETSTATS_NB_SUCCESS = 0,/**< Successful transmission */ | ||
| NETSTATS_NB_NOACK, /**< Failed due to no ack received */ | ||
| NETSTATS_NB_SUCCESS, /**< Successful transmission */ | ||
| NETSTATS_NB_BUSY, /**< Failed due to medium busy */ | ||
| } netstats_nb_result_t; |
There was a problem hiding this comment.
Suggested change
| typedef enum { | |
| NETSTATS_NB_BUSY, /**< Failed due to medium busy */ | |
| NETSTATS_NB_SUCCESS = 0,/**< Successful transmission */ | |
| NETSTATS_NB_NOACK, /**< Failed due to no ack received */ | |
| NETSTATS_NB_SUCCESS, /**< Successful transmission */ | |
| NETSTATS_NB_BUSY, /**< Failed due to medium busy */ | |
| } netstats_nb_result_t; | |
| typedef enum { | |
| NETSTATS_NB_SUCCESS = 0, /**< Successful transmission */ | |
| NETSTATS_NB_NOACK, /**< Failed due to no ack received */ | |
| NETSTATS_NB_BUSY, /**< Failed due to medium busy */ | |
| } netstats_nb_result_t; |
The static tests don't like the missing space between , and /**...*/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
These were only updated with in the old TX_COMPLETE events that no longer exist with the new API.
Testing procedure
tbd
Issues/PRs references