Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/at86rf215: return ENETDOWN when interface is down [backport 2024.10] #21037

Merged
merged 4 commits into from
Nov 26, 2024
Merged

drivers/at86rf215: return ENETDOWN when interface is down [backport 2024.10] #21037

merged 4 commits into from
Nov 26, 2024

Conversation

benpicco
Copy link
Contributor

Backport of #21031

Contribution description

We would return EBUSY when the interface was in sleep, this caused the gnrc_netif to retry sending forever. Return ENETDOWN instead.

I added three additional minor fixes to this to not bother CI with those trivial changes:

  • better error messages in gnrc_netif to tell apart the case where a pkt can't be queued and is dropped and where we try sending it instead
  • wrong rx buffer size in the nanocoap_cli test
  • overwriting tx_frame_len that has already been set in at86rf215_tx_load()

Testing procedure

Issues/PRs references

@benpicco benpicco added Area: drivers Area: Device drivers Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 25, 2024
@benpicco benpicco requested a review from maribu November 25, 2024 11:55
@benpicco benpicco enabled auto-merge November 25, 2024 13:49
@riot-ci
Copy link

riot-ci commented Nov 25, 2024

Murdock results

✔️ PASSED

969ca83 test/net/nanocoap_cli: fix buffer size for get_non

Success Failures Total Runtime
10214 0 10215 20m:12s

Artifacts

@benpicco benpicco added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 25, 2024
@maribu maribu added this pull request to the merge queue Nov 25, 2024
Merged via the queue into RIOT-OS:2024.10-branch with commit 0e82225 Nov 26, 2024
33 checks passed
@benpicco benpicco deleted the backport/2024.10/net_fixes-misc branch November 26, 2024 08:58
@benpicco benpicco modified the milestones: 2024.10, Release 2024.10 Nov 26, 2024
@benpicco benpicco modified the milestones: 2024.10, Release 2024.07, Release 2024.10 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2024.10
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @riot-ci @maribu