Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/rtc_utils: make parameter to rtc_mktime() const #21096

Merged
merged 1 commit into from
Dec 19, 2024
Merged

sys/rtc_utils: make parameter to rtc_mktime() const #21096

merged 1 commit into from
Dec 19, 2024
+2 −2

Conversation

benpicco
Copy link
Contributor

Contribution description

The function does not modify it, so make the time struct const

Testing procedure

Issues/PRs references

@benpicco benpicco changed the title sys/rtc_utils: make parameter to rtc_mktime() const sys/rtc_utils: make parameter to rtc_mktime() const Dec 18, 2024
@github-actions github-actions bot added the Area: sys Area: System label Dec 18, 2024
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Dec 18, 2024
@riot-ci
Copy link

riot-ci commented Dec 18, 2024

Murdock results

✔️ PASSED

ba0060d sys/rtc_utils: make parameter to rtc_mktime() const

Success Failures Total Runtime
10249 0 10249 16m:41s

Artifacts

@benpicco benpicco requested review from aabadie and maribu December 19, 2024 10:49
@maribu maribu enabled auto-merge December 19, 2024 10:50
@maribu maribu added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@maribu maribu added this pull request to the merge queue Dec 19, 2024
Merged via the queue into RIOT-OS:master with commit 4f55461 Dec 19, 2024
28 checks passed
@benpicco benpicco deleted the rtc_mktime-const branch December 19, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@aabadie aabadie Awaiting requested review from aabadie

Assignees
No one assigned
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @riot-ci @maribu