pkg/nimble: Update to 1.8.0 #21108
Draft
pkg/nimble: Update to 1.8.0 #21108
+385
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: pkg
chrysn
added
the
CI: ready for build
|
@sjanc, could you help me here? I'm always running into |
These were found by hunting down assertion errors' causes.
I don't have the time or experience to debug a platform where I don't have devkits; let's see if all others (that's just nRF, right?) pass CI with this.
github-actions
bot
added
Platform: ESP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This updates nimble, with all the adjustments that need to go with it.
Testing procedure
make -C examples/nimble_heart_rate_sensor all flash termon any supported board (I'm using on nrf52dk)Issues/PRs references
Updating this is a prerequisite to using ready-made Rust wrappers on nimble (eg. https://github.com/embassy-rs/trouble/), which is preferable over safely wrapping the whole API surface just once ore.
Current status
Not getting it to build yet; we'll need some patches for upstream problems (not following IWYU) and our dead-code strictness -- and then (currently: after fixing them manually), a few symbols are missing, which should be easy to fix but is still a tedious task.[edit: It builds now, but is not tested yet]
All patches should be upstreamed.