Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: transform test apps into unittests where it makes sense #2176

Closed
wants to merge 2 commits into from
Closed

tests: transform test apps into unittests where it makes sense #2176

wants to merge 2 commits into from

Conversation

phiros
Copy link
Member

@phiros phiros commented Dec 10, 2014

This should fix issue #1131.

  • tests/bloom -> unittests/tests-bloom
  • tests/bloom_bytes (unsure about this one; essentially a performance test)
  • tests/net_if
  • tests/posix_semaphore
  • tests/sha256 -> unittest/tests-crypto/tests-crypto-sha256.c (btw: currently, the test coverage for crypto is quite poor)

@phiros phiros added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Area: tests Area: tests and testing framework Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Dec 10, 2014
@miri64
Copy link
Member

miri64 commented Dec 10, 2014

A PR consisting of a single [SQUASH ME] commit? That's new ^^.

@phiros phiros force-pushed the tests_transform_test_apps_into_unittests branch from 9c14f45 to 73de904 Compare December 10, 2014 23:51
@phiros phiros force-pushed the tests_transform_test_apps_into_unittests branch from 73de904 to 00773e6 Compare December 10, 2014 23:57
@phiros
Copy link
Member Author

phiros commented Dec 11, 2014

@authmillenon I was in a hurry when I pushed that (Also, I added the WIP label for a reason ;-) )

BTW: just added another commit.

@miri64 miri64 self-assigned this Dec 11, 2014
miri64
miri64 reviewed Dec 11, 2014
View reviewed changes
tests/unittests/tests-bloom/tests-bloom.c
EMB_UNIT_TESTFIXTURES(fixtures) {
new_TestFixture(test_bloom_parameters_bytes_hashf),
new_TestFixture(test_bloom_based_on_dictionary_fixture),
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird indentation

@LudwigKnuepfer
Copy link
Member

I would suggest splitting this PR into smaller chunks - or rather not work the remaining TODOs within this PR but open new PRs/issues for each them.

@phiros
Copy link
Member Author

phiros commented Dec 11, 2014

@LudwigOrtmann I'll split up the PR. Makes more sense.

@phiros
Copy link
Member Author

phiros commented Dec 11, 2014

tests/sha256 -> unittests now in in #2181

@phiros phiros closed this Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miri64 miri64

Labels
Area: tests Area: tests and testing framework State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phiros @miri64 @LudwigKnuepfer