ng_icmpv6: Initial import #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Area: network
36 tasks
miri64
force-pushed
the
ng_icmpv6/feat/initial
branch
4 times, most recently
from
7b5d706 to
89a23fd
Compare
|
Rebased to current #2454 |
miri64
force-pushed
the
ng_icmpv6/feat/initial
branch
2 times, most recently
from
7f1b556 to
33de13f
Compare
|
Rebased to current #2454 |
miri64
force-pushed
the
ng_icmpv6/feat/initial
branch
2 times, most recently
from
e36047f to
43e113f
Compare
|
Rebased to current #2454 |
This was referenced Mar 19, 2015
miri64
force-pushed
the
ng_icmpv6/feat/initial
branch
from
ce1af46 to
8b66701
Compare
|
Rebased to current #2454 |
miri64
force-pushed
the
ng_icmpv6/feat/initial
branch
from
6ae135e to
8f929a8
Compare
|
Rebased and adapted to changes in #2454. Since they were quite big, I squashed. |
miri64
removed
the
State: WIP
|
(No longer WIP) |
| break; | ||
| } | ||
|
|
||
| /* ICMPv6-all will be send send in ng_ipv6.c so only dispatch of |
|
Addressed comments |
| return _echo_build(NG_ICMPV6_ECHO_REQ, id, seq, data, data_len); | ||
| } | ||
|
|
||
| ng_pktsnip_t *ng_icmpv6_echo_rep_build(uint16_t id, uint16_t seq, uint8_t *data, size_t data_len) |
There was a problem hiding this comment.
Any reason not to inline these functions now?
There was a problem hiding this comment.
Because I need to expose the generic function for this. Anyways: just did that.
OlegHahm
added
the
CI: needs squashing
|
|
||
| ng_pktbuf_hold(pkt, ng_netreg_num(NG_NETTYPE_IPV6, NG_NETREG_DEMUX_CTX_ALL) - 1); | ||
|
|
||
| /* ICMPv6 is not interested anymore so `- 1` */ |
There was a problem hiding this comment.
Wouldn't this comment make more sense if written right before ng_pktbuf_hold()?
|
Addressed comments |
|
ACK. Please squash and go if Travis agrees. |
miri64
force-pushed
the
ng_icmpv6/feat/initial
branch
from
5f77067 to
8be0772
Compare
|
Squashed |
miri64
removed
the
CI: needs squashing
miri64
force-pushed
the
ng_icmpv6/feat/initial
branch
from
8be0772 to
8e1f4a2
Compare
miri64
force-pushed
the
ng_icmpv6/feat/initial
branch
from
8e1f4a2 to
229f49a
Compare
|
Had to fix something: since the types of the echo request/reply were now exposed, I needed to put them somewhere else than ng_icmpv6.h => introduced ng_icmpv6/types.h |
|
Please re-ACK. |
|
I think that's fine. ACK and go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2454 and all its dependencies.