Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpl: pass rpl_instance_t directly instead of its id #2604

Merged
merged 1 commit into from
Mar 18, 2015
Merged

rpl: pass rpl_instance_t directly instead of its id #2604

merged 1 commit into from
Mar 18, 2015

Conversation

cgundogan
Copy link
Member

Instead of passing the id of a rpl_instance_t struct to look it up in rpl_new_dodag(), I suggest to pass the struct itself to the function.

@cgundogan cgundogan added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. labels Mar 16, 2015
@cgundogan cgundogan added Area: network Area: Networking and removed Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Mar 16, 2015
@BytesGalore BytesGalore mentioned this pull request Mar 17, 2015
Closed
21 tasks
@OlegHahm
Copy link
Member

ACK, tested and works. Go!

OlegHahm added a commit that referenced this pull request Mar 18, 2015
@OlegHahm
Merge pull request #2604 from cgundogan/rpl_use_instance_t_as_parameter
c396a90 
rpl: pass rpl_instance_t directly instead of its id
@OlegHahm OlegHahm merged commit c396a90 into RIOT-OS:master Mar 18, 2015
@cgundogan cgundogan deleted the rpl_use_instance_t_as_parameter branch March 18, 2015 17:19
jnohlgard pushed a commit to jnohlgard/RIOT that referenced this pull request Mar 21, 2015
rpl: Fix DEBUG print which broke in 5585413
8865d9f 
rpl: pass rpl_instance_t directly instead of its id RIOT-OS#2604
RIOT-OS#2604
@jnohlgard jnohlgard mentioned this pull request Mar 21, 2015
Merged
jnohlgard pushed a commit that referenced this pull request Mar 31, 2015
@OlegHahm
rpl: Fix DEBUG print which broke in 5585413
7a1cffa 
rpl: pass rpl_instance_t directly instead of its id #2604
#2604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@OlegHahm OlegHahm

Labels
Area: network Area: Networking Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgundogan @OlegHahm