rpl: remove global variable indicating the root node #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgundogan
added
Type: enhancement
cgundogan
force-pushed
the
rpl_remove_global_root_indication
branch
from
7170619 to
549b5d3
Compare
cgundogan
added
the
State: waiting for other PR
|
needs rebase |
OlegHahm
removed
the
State: waiting for other PR
cgundogan
force-pushed
the
rpl_remove_global_root_indication
branch
from
549b5d3 to
e20fbbb
Compare
|
rebased to current master |
| uint8_t rpl_is_root(void) | ||
| { | ||
| return i_am_root; | ||
| for (uint8_t i = 0; i < RPL_MAX_DODAGS; i++) { |
There was a problem hiding this comment.
to keep the code consistent it would be nice to iterate like you did for instance here
OlegHahm
force-pushed
the
master
branch
3 times, most recently
from
9f184dd to
45554bf
Compare
|
addressed @BytesGalore's comment to change the style of the for-loop |
OlegHahm
added
the
CI: needs squashing
|
after merging #2831 my tests succeed. ACK. Please squash! |
cgundogan
force-pushed
the
rpl_remove_global_root_indication
branch
from
0395f8b to
b557000
Compare
cgundogan
removed
the
CI: needs squashing
|
@OlegHahm squashed and rebased |
OlegHahm
added a commit
that referenced
this pull request
Apr 29, 2015
…tion rpl: remove global variable indicating the root node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A global variable
i_am_rootis used to decide if the node is initialized as root or as a normal node. This approach makes it impossible to handle multiple dodags, because the device could be a normal node for one dodag and root for another.