rpl: pass dodag to the rpl_find_parent function #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgundogan
added
Type: enhancement
| if ((parent->used) && (rpl_equal_id(address, &parent->addr) | ||
| && (parent->dodag->instance->id == dodag->instance->id) | ||
| && !memcmp(&parent->dodag->dodag_id, | ||
| &dodag->dodag_id, sizeof(ipv6_addr_t)))) { |
|
Apart from the missing parentheses: ACKt |
cgundogan
force-pushed
the
rpl_pass_dodag_to_find_parent
branch
from
354275e to
5fb526f
Compare
|
addressed @OlegHahm's comment to add parens |
|
added the missing parens and travis is building => GO |
cgundogan
added a commit
that referenced
this pull request
Mar 20, 2015
rpl: pass dodag to the rpl_find_parent function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the condition to find a parent by checking if it belongs to the dodag. Otherwise, the function could return a parent belonging to another dodag.