-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipv6_hdr: Initial import #2731
ipv6_hdr: Initial import #2731
Conversation
@@ -48,6 +48,10 @@ ifneq (,$(filter sixlowpan,$(USEMODULE))) | |||
USEMODULE += vtimer | |||
endif | |||
|
|||
ifneq (,$(filter ng_ipv6_hdr,$(USEMODULE))) | |||
USEMODULE += ng_inet_csum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally unrelated to this PR: The prefix NG sucks. Whats next? NNG -- "the next new negeration"? After that ENNG "even newer next generation"? UMNGT -- "ultimate mighty next generation thingy"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to remove this prefix as soon as the new stack is stable and the old one can be removed. We did this primarily to keep colisions with the old stack as low as possible. When the network stack is done, there will be a big rename commit and ng_
will be a thing of the past ;-)
9f184dd
to
45554bf
Compare
* +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | ||
* |Version| Traffic Class | Flow Label | | ||
* +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | ||
* @endcode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it make sense to paste the complete packet structure from the RFC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that
ACK - if comment is addressed, Travis is happy and PR is squashed. |
8b12d9e
to
7a3c373
Compare
Rebased to current #2730 and squashed. |
Taken out of #2454 to be used by other PRs that need this header (e.g. #2430).
Based on #2730 for checksum calculation (merged).