cpu: samd21: fix gpio irq handling compile handling #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes an issue by an PR that's not even merged? |
OlegHahm
added
Platform: ARM
|
@OlegHahm The PR exposed a bug. |
|
this PR does suppress the warning, but does not fix the issue: |
|
Wait, if we set I do understand why it needs a rewrite ... |
21 tasks
|
@OlegHahm Could you give this a try? |
| @@ -36,7 +36,7 @@ typedef struct { | |||
| void *arg; /**< argument passed to the callback */ | |||
| } gpio_state_t; | |||
|
|
|||
| static gpio_state_t gpio_config[GPIO_NUMOF]; | |||
| static gpio_state_t gpio_config[16]; | |||
There was a problem hiding this comment.
please replace with a non-literal
|
This PR alone seems to work - will test with #2852. |
|
ACK, please squash. |
OlegHahm
added
the
CI: needs squashing
|
ACK |
|
Third ACK. Please squash :-) |
kaspar030
force-pushed
the
fix_samd21_gpio_compile_issue
branch
from
4fadabf to
aff2593
Compare
|
squashed, rebased |
OlegHahm
removed
the
CI: needs squashing
PeterKietzmann
added
the
CI: ready for build
|
And go |
PeterKietzmann
added a commit
that referenced
this pull request
May 26, 2015
cpu: samd21: fix gpio irq handling compile handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes compile issue exposed in #2852 (bug shows when compiling with -Os)
(this gpio implementation needs a complete rewrite)