-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/fib: added configuration header for the FIB #3022
net/fib: added configuration header for the FIB #3022
Conversation
I think I was one of the people who were pro having this header, but thinking about it again, I was wondering if it would make sense to make some of the fields configurable through functions, more specifically |
@Lotterleben good point. I like the idea to configure stuff on compile time like |
thanks :) |
5bebb6f
to
a3b4e08
Compare
@Lotterleben changed to configure on compile time, but this may produce unwanted side-effects. When including the You can reproduce it by e.g. printing the value of the defines in the FIB (e.g. in |
Hrrrrm thats not good :( If this is the case, it shouldn't be used, but there must be a way... I'll think about it some more on my way to the Uni. |
Okay, I've opened an issue to document this: #3256 |
a3b4e08
to
8df3a4a
Compare
@Lotterleben agreed, removed the command line configuration possibility. |
thanks, then.. ack if travis says yes |
|
228f294
to
2e89275
Compare
2e89275
to
3914716
Compare
needs rebase |
Just wondering, do we still want to pursue this one? :) |
@Lotterleben I still want to do the housekeeping for the cluttered FIB configuration properties :). |
Rationale: this introduces a new header to easily configure the FIB.
Mainly to provide one configuration file for all important defines, i.e. sizes for the actual data fields for FIB entries and universal addresses, and message types.