Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lpc2387: Add missing exception tables to linker script #3116

Merged
merged 1 commit into from
Jun 24, 2015

Conversation

jnohlgard
Copy link
Member

Copied from kinetis_common

Found during build test of #3115

@jnohlgard jnohlgard added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: ARM Platform: This PR/issue effects ARM-based platforms CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 30, 2015
@jnohlgard
Copy link
Member Author

rebased after #3120 was merged.

@jnohlgard jnohlgard added this to the Release 2015.06 milestone May 31, 2015
@jnohlgard
Copy link
Member Author

Could someone with an msba2 board, or other lpc2387, test this to make sure it still runs?

@jnohlgard
Copy link
Member Author

Who has an msba2, pttu or avsextrem board available for testing?

@OlegHahm
Copy link
Member

OlegHahm commented Jun 3, 2015

Sorry, won't be able to test for the next 2,5 weeks. There are some MSB-A2 boards at FU Berlin (@haukepetersen, @kaspar030) and at HAW (@BytesGalore, @Lotterleben).

@jnohlgard
Copy link
Member Author

It would be nice if we could get this merged in time for release 2015.06. This issue blocks C++ support on those boards.

@jnohlgard
Copy link
Member Author

ping @BytesGalore

@BytesGalore
Copy link
Member

wow sorry, missed this one.
Will test now

@BytesGalore
Copy link
Member

ok so far,

  • the basic examples without c++ work on the msba2
  • the simple example\riot_and_cpp also works

building tests/cpp11_* generates the same errors with and without this PR:

/RIOT/tests/cpp11_mutex/bin/msba2/cpp11_mutex.a(main.o): In function `std::__atomic_base<unsigned int>::operator--()':
/gcc-arm-none-eabi-4_9-2015q1/arm-none-eabi/include/c++/4.9.3/bits/atomic_base.h:416: undefined reference to `__atomic_fetch_sub_4'
/gcc-arm-none-eabi-4_9-2015q1/bin/../lib/gcc/arm-none-eabi/4.9.3/../../../../arm-none-eabi/lib/libstdc++.a(system_error.o): In function `_GLOBAL__sub_I__ZNSt14error_categoryD2Ev':
system_error.cc:(.text.startup._GLOBAL__sub_I__ZNSt14error_categoryD2Ev+0x30): undefined reference to `__dso_handle'
/gcc-arm-none-eabi-4_9-2015q1/bin/../lib/gcc/arm-none-eabi/4.9.3/../../../../arm-none-eabi/bin/ld: /home/user01/Schreibtisch/RIOT/tests/cpp11_thread/bin/msba2/cpp11_thread.elf: hidden symbol `__dso_handle' isn't defined
/gcc-arm-none-eabi-4_9-2015q1/bin/../lib/gcc/arm-none-eabi/4.9.3/../../../../arm-none-eabi/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
/RIOT/tests/cpp11_thread/../../Makefile.include:186: recipe for target 'all' failed
make: *** [all] Error 1

but they seem unrelated (or only related to my compiler version)
will test additionally with code sourcery.

@BytesGalore
Copy link
Member

ok, its the same for the code sourcery compiler gcc version 4.8.3 20140320 (prerelease) (Sourcery CodeBench Lite 2014.05-28) [1]
(The one before was compiled with the launchpad version)

[1] https://github.com/RIOT-OS/RIOT/wiki/Family:-ARM#codebench-for-linux

@jnohlgard
Copy link
Member Author

The C++11 examples are not expected to run with this change alone, but this PR is a prerequisite for #3107
@BytesGalore Do I have your ACK for this change?

@BytesGalore
Copy link
Member

@gebart In that case yes, ACK :)

jnohlgard pushed a commit that referenced this pull request Jun 24, 2015
lpc2387: Add missing exception tables to linker script
@jnohlgard jnohlgard merged commit fc4ab35 into RIOT-OS:master Jun 24, 2015
@jnohlgard jnohlgard deleted the pr/lpc2387-extab branch June 24, 2015 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants