ng_sixlowpan_ctx: add compression flag support #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: bug
|
Ping? |
miri64
force-pushed
the
ng_sixlowpan_ctx/api/comp-flag
branch
from
23c81a7 to
8ea1a1c
Compare
|
Rebased and adapted for changes in #3159. |
| */ | ||
| static inline void ng_sixlowpan_ctx_remove(uint8_t id) | ||
| { | ||
| ng_sixlowpan_ctx_lookup_id(id)->prefix_len = 0; |
There was a problem hiding this comment.
I would argue that one doesn't need a function for it, but that's only a weak opinion.
There was a problem hiding this comment.
That's why it is a inline function.
There was a problem hiding this comment.
I noticed, but after all this is just a suggestion to the compiler.
|
Adressed comments |
OlegHahm
added
the
CI: needs squashing
|
ACK, please squash! |
The compression flag allows a context to be invalidated for compression, but still be valid for decompression. This is needed for context dissimination in a LoWPAN.
miri64
force-pushed
the
ng_sixlowpan_ctx/api/comp-flag
branch
from
8fcc7fc to
e6747b8
Compare
|
Squashed. |
miri64
added
the
CI: ready for build
miri64
removed
the
CI: needs squashing
OlegHahm
added a commit
that referenced
this pull request
Jul 17, 2015
…flag ng_sixlowpan_ctx: add compression flag support
| } | ||
| } | ||
|
|
||
| if ((src_ctx != NULL) || ng_ipv6_addr_is_link_local(&(ipv6_hdr->src))) { | ||
| eui64_t iid; | ||
| eui64_t iid = { 0 }; |
There was a problem hiding this comment.
I'm getting the following error:
.../riot/sys/net/network_layer/ng_sixlowpan/iphc/ng_sixlowpan_iphc.c: In function ‘ng_sixlowpan_iphc_encode’:
.../riot/sys/net/network_layer/ng_sixlowpan/iphc/ng_sixlowpan_iphc.c:502:13: error: missing braces around initializer [-Werror=missing-braces]
eui64_t iid = { 0 };
^
.../riot/sys/net/network_layer/ng_sixlowpan/iphc/ng_sixlowpan_iphc.c:502:13: error: (near initialization for ‘iid.uint64’) [-Werror=missing-braces]
There was a problem hiding this comment.
eui64_t iid = { .uint64.u64 = 0, }; works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compression flag allows a context to be invalidated for compression, but still be valid for decompression. This is needed for context dissimination in a LoWPAN.